On Thu, 3 Nov 2016, Diego Biurrun wrote:
On Thu, Nov 03, 2016 at 02:32:10PM +0200, Martin Storsjö wrote:
In aacps_tablegen.h, only include libm.h if building for the target.
If actual fallbacks are needed here (in practice, sinf and cosf,
which are missing on Plan 9 - they are present even on MSVC), we need
to include libm.h, but this relies on configure test results for the
target. These test results can't be used for the host (e.g. when this
header is used when building with --enable-hardcoded-tables).
This clearly breaks builds with hardcoded tables on Plan 9 (not
cross builds from another host to Plan 9 though), instead of relying on
coincidences that config.h for the target might match the host build
config as well.
So, speaking of Plan 9, IMO we should discuss if keeping support for it
is worth the trouble. It was a nice joke and pun with the 9 release, but
that has run its course.
Well, keeping it in itself isn't too much trouble, except we have no idea
if it still works, and for things like this particular include of libm.h,
I can't test. That said, I'm not opposed to removing it either, bringing
the set of things back to things we test regularly.
--- a/configure
+++ b/configure
@@ -3719,6 +3719,7 @@ check_cc -D_LARGEFILE_SOURCE <<EOF && add_cppflags
-D_LARGEFILE_SOURCE
EOF
add_host_cppflags -D_ISOC99_SOURCE
+add_host_cppflags -DHOST_BUILD
You can merge these two lines.
Ah, yes
// Martin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
