On Mon, Nov 07, 2016 at 04:14:11PM -0500, Vittorio Giovara wrote:
> --- /dev/null
> +++ b/libavutil/spherical.h
> @@ -0,0 +1,99 @@
> +/**
> + * Projection of the video surface(s) on a sphere.
> + */
For these and similar doxygen comments I always wonder why they have to
span 3 lines and take up so much screen real estate. Yes, it's done
everywhere...
> +typedef struct AVSphericalMapping {
> + /**
> + * Projection type.
> + */
> + enum AVSphericalProjection projection;
> +
> + /* @defgroup orientation
> + * @{
> + * Pose values measuring rotation in degrees to be applied to the
> + * projection. The transform order should be yaw, pitch, and roll.
> + */
This comment is not doxygen and the defgroup is missing a title after
the name.
> + /**
> + * @defgroup bounds
> + * @{
> + * Amount of pixels to crop the edge of the video surface.
> + * @note for cubemap projections these values apply to each face.
> + */
same
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
