On Mon, Nov 21, 2016 at 10:46:45AM -0500, Vittorio Giovara wrote:
> On Mon, Nov 21, 2016 at 8:52 AM, Diego Biurrun <di...@biurrun.de> wrote:
> > --- a/libavcodec/dvbsubdec.c
> > +++ b/libavcodec/dvbsubdec.c
> > @@ -32,8 +32,6 @@
> > #define DVBSUB_DISPLAYDEFINITION_SEGMENT 0x14
> > #define DVBSUB_DISPLAY_SEGMENT 0x80
> >
> > -#define cm (ff_crop_tab + MAX_NEG_CROP)
> > -
> > #ifdef DEBUG
> > static void png_save(const char *filename, uint32_t *bitmap, int w, int h)
> > {
> > --- a/libavcodec/dvdsubdec.c
> > +++ b/libavcodec/dvdsubdec.c
> > @@ -35,7 +35,6 @@ typedef struct DVDSubContext {
> >
> > static void yuv_a_to_rgba(const uint8_t *ycbcr, const uint8_t *alpha,
> > uint32_t *rgba, int num_values)
> > {
> > - const uint8_t *cm = ff_crop_tab + MAX_NEG_CROP;
> > uint8_t r, g, b;
> > int i, y, cb, cr;
> > int r_add, g_add, b_add;
> > --- a/libavcodec/pgssubdec.c
> > +++ b/libavcodec/pgssubdec.c
> > @@ -324,7 +324,6 @@ static int parse_palette_segment(AVCodecContext *avctx,
> > PGSSubPalette *palette;
> >
> > const uint8_t *buf_end = buf + buf_size;
> > - const uint8_t *cm = ff_crop_tab + MAX_NEG_CROP;
> > int color_id;
> > int y, cb, cr, alpha;
> > int r, g, b, r_add, g_add, b_add;
> > --- a/libavutil/colorspace.h
> > +++ b/libavutil/colorspace.h
> > @@ -27,6 +27,8 @@
> > #ifndef AVUTIL_COLORSPACE_H
> > #define AVUTIL_COLORSPACE_H
> >
> > +#define cm (ff_crop_tab + MAX_NEG_CROP)
>
> Wait ff_crop_tab is a table defined in libavcodec right? It doesn't
> seem right to reference it here.
Yes, that was a brainfart.
> Also there are a bunch of other places where this could be replaced.
Looking into it ...
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
