On Sat, Dec 03, 2016 at 05:45:24PM -0500, Vittorio Giovara wrote: > On Sat, Dec 3, 2016 at 1:49 AM, Diego Biurrun <di...@biurrun.de> wrote: > > @@ -1971,13 +1980,17 @@ fic_decoder_select="golomb" > > flac_decoder_select="flacdsp golomb" > > flac_encoder_select="bswapdsp flacdsp golomb lpc" > > flashsv_decoder_deps="zlib" > > +flashsv_decoder_extralibs="zlib_extralibs" > > flashsv_encoder_deps="zlib" > > +flashsv_encoder_extralibs="zlib_extralibs" > > flashsv2_decoder_deps="zlib" > > +flashsv2_decoder_extralibs="zlib_extralibs" > > flv_decoder_select="h263_decoder" > > flv_encoder_select="h263_encoder" > > fourxm_decoder_select="blockdsp bswapdsp" > > fraps_decoder_select="bswapdsp huffman" > > g2m_decoder_deps="zlib" > > +g2m_decoder_extralibs="zlib_extralibs" > > g2m_decoder_select="blockdsp idctdsp jpegtables" > > h261_decoder_select="mpeg_er mpegvideo" > > h261_encoder_select="aandcttables mpegvideoenc" > > @@ -2050,7 +2064,9 @@ on2avc_decoder_select="mdct" > > opus_decoder_deps="avresample" > > opus_decoder_select="imdct15" > > png_decoder_deps="zlib" > > +png_decoder_extralibs="zlib_extralibs" > > png_encoder_deps="zlib" > > +png_encoder_extralibs="zlib_extralibs" > > png_encoder_select="huffyuvencdsp" > > prores_decoder_select="idctdsp" > > prores_encoder_select="fdctdsp" > > @@ -2059,6 +2075,7 @@ qdm2_decoder_select="mdct rdft mpegaudiodsp" > > ra_144_encoder_select="audio_frame_queue lpc" > > ralf_decoder_select="golomb" > > rscc_decoder_deps="zlib" > > +rscc_decoder_extralibs="zlib_extralibs" > > rv10_decoder_select="error_resilience h263_decoder h263dsp mpeg_er" > > rv10_encoder_select="h263_encoder" > > rv20_decoder_select="error_resilience h263_decoder h263dsp mpeg_er" > > @@ -2066,6 +2083,7 @@ rv20_encoder_select="h263_encoder" > > rv30_decoder_select="error_resilience golomb h264chroma h264pred h264qpel > > mpeg_er mpegvideo rv34dsp videodsp" > > rv40_decoder_select="error_resilience golomb h264chroma h264pred h264qpel > > mpeg_er mpegvideo rv34dsp videodsp" > > screenpresso_decoder_deps="zlib" > > +screenpresso_decoder_extralibs="zlib_extralibs" > > shorten_decoder_select="golomb" > > sipr_decoder_select="lsp" > > sp5x_decoder_select="mjpeg_decoder" > > @@ -2073,17 +2091,22 @@ svq1_decoder_select="hpeldsp" > > svq1_encoder_select="aandcttables hpeldsp me_cmp mpegvideoenc" > > svq3_decoder_select="golomb h264dsp h264parse h264pred hpeldsp tpeldsp > > videodsp" > > svq3_decoder_suggest="zlib" > > +svq3_decoder_extralibs="zlib_extralibs" > > tak_decoder_select="audiodsp" > > tdsc_decoder_deps="zlib" > > +tdsc_decoder_extralibs="zlib_extralibs" > > tdsc_decoder_select="mjpeg_decoder" > > theora_decoder_select="vp3_decoder" > > thp_decoder_select="mjpeg_decoder" > > +tiff_decoder_extralibs="zlib_extralibs" > > tiff_decoder_suggest="zlib" > > +tiff_encoder_extralibs="zlib_extralibs" > > tiff_encoder_suggest="zlib" > > truehd_decoder_select="mlp_decoder" > > truemotion2_decoder_select="bswapdsp" > > truespeech_decoder_select="bswapdsp" > > tscc_decoder_deps="zlib" > > +tscc_decoder_extralibs="zlib_extralibs" > > txd_decoder_select="texturedsp" > > twinvq_decoder_select="mdct lsp sinewin" > > utvideo_decoder_select="bswapdsp" > > @@ -2115,10 +2138,15 @@ wmv2_encoder_select="h263_encoder wmv2dsp" > > wmv3_decoder_select="vc1_decoder" > > wmv3image_decoder_select="wmv3_decoder" > > zerocodec_decoder_deps="zlib" > > +zerocodec_decoder_extralibs="zlib_extralibs" > > zlib_decoder_deps="zlib" > > +zlib_decoder_extralibs="zlib_extralibs" > > zlib_encoder_deps="zlib" > > +zlib_encoder_extralibs="zlib_extralibs" > > zmbv_decoder_deps="zlib" > > +zmbv_decoder_extralibs="zlib_extralibs" > > zmbv_encoder_deps="zlib" > > +zmbv_encoder_extralibs="zlib_extralibs" > > Why cannot *_extralibs be automatically added? > Especially below it adds one entry for each component, which I find a > little too much.
There are 24 components that depend on zlib, so yeah, this is a tad verbose. > Not judging the technical benefits of this patch, isn't there a more > succinct way of coding this? One could try to add the extralibs of each dependency to the extralibs of each component. This requires making the dependency resolver somewhat smarter. That is a nontrivial task, I'll think about it. Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
