On Fri, Dec 2, 2016 at 4:52 PM, Andreas Cadhalpun
<andreas.cadhal...@googlemail.com> wrote:
> On 02.12.2016 18:07, Vittorio Giovara wrote:
>> On Sun, Nov 13, 2016 at 5:25 PM, Andreas Cadhalpun
>> <andreas.cadhal...@googlemail.com> wrote:
>>> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com>
>>> ---
>>> libavcodec/libschroedingerdec.c | 26 +++++++++++++++++---------
>>> 1 file changed, 17 insertions(+), 9 deletions(-)
>>>
>>> @@ -308,10 +314,9 @@ static int libschroedinger_decode_frame(AVCodecContext
>>> *avctx,
>>> framewithpts = ff_schro_queue_pop(&p_schro_params->dec_frame_queue);
>>>
>>> if (framewithpts && framewithpts->frame &&
>>> framewithpts->frame->components[0].stride) {
>>> - int ret;
>>>
>>> - if ((ret = ff_get_buffer(avctx, avframe, 0)) < 0)
>>> - return ret;
>>> + if ((ret = ff_get_buffer(avctx, avframe, 0)) < 0) {}
>>> + goto end;
>>
>> this seems dangerous
>
> That's wrong, of course, but the patch is superseded by the attached one,
> anyway.
> I just forgot to CC the libav.org mailing list. Sigh...
Yeah this looks good to me, queueing the set.
--
Vittorio
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
