On 13/01/17 11:07, Anton Khirnov wrote: > Quoting Mark Thompson (2017-01-10 00:47:55) >> --- >> The i965 driver has been updated so that this works consistently. >> >> libavcodec/vaapi_encode.c | 14 ++++++++++++++ >> libavcodec/vaapi_encode.h | 4 ++++ >> 2 files changed, 18 insertions(+) >> > > Code itself looks ok, but won't old versions of the driver misbehave?
It will make the bitrate-targetted RC modes for VP8 and VP9 do nasty things with the Intel driver before 1.8.0. Would you prefer this to have some sort of hack to try to parse the Intel driver version out of the vendor string and fail out for some codecs? (That's the only way I can see to test it - the API is clear that this has always been valid, it was just the driver which didn't implement it properly.) For VP8 it's essentially irrelevant because the driver is so terrible in current versions that noone in their right mind would ever use it (there are now patches outstanding on the libva list which make it usable). For VP9 it's unfortunate because it does already work mostly sensibly, but given how recent the hardware is one would hope that people aren't going to blindly expect an earlier version of libva to work properly? _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
