On Sun, Feb 05, 2017 at 11:41:40AM +0100, Janne Grunau wrote:
> On 2017-01-24 18:12:47 +0100, Diego Biurrun wrote:
> > This allows distinguishing between the internal variable name for
> > external libraries and the pkg-config package name. Having both
> > names available avoids special-casing outside the helper function
> > when the two identifiers do not match.
> > ---
> > configure | 59 +++++++++++++++++++++++++++++++----------------------------
> > 1 file changed, 31 insertions(+), 28 deletions(-)
> >
> > diff --git a/configure b/configure
> > index 747ce17..d3fd489 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1134,11 +1134,14 @@ require_cpp_condition(){
> >
> > require_pkg_config(){
> > log require_pkg_config "$@"
> > - pkg_version="$1"
> > - pkg="${1%% *}"
> > + name="$1"
>
> shift here and pkg and pkg_version do not to be modified
>
> > + pkg_version="$2"
> > + pkg="${2%% *}"
> > + shift
> > + test "$name" = "" && name=$pkg
Yes, it would reduce the diff size slightly, but all the other functions shift
after assigning all the variables making this one the odd man out. I'd prefer
not to.
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
