On Mon, Mar 27, 2017 at 12:59:13PM +0200, Vittorio Giovara wrote: > On Mon, Mar 27, 2017 at 12:17 PM, Diego Biurrun <di...@biurrun.de> wrote: > > On Fri, Mar 24, 2017 at 04:47:55PM +0100, Vittorio Giovara wrote: > >> On Fri, Mar 24, 2017 at 4:10 PM, Diego Biurrun <di...@biurrun.de> wrote: > >> > + bytestream2_init(gb, avpkt->data, avpkt->size); > >> > + bytestream2_skip(gb, 2); > >> > + > >> > + frame->key_frame = !!bytestream2_get_le16(gb); > >> > + frame->pict_type = frame->key_frame ? AV_PICTURE_TYPE_I : > >> > AV_PICTURE_TYPE_P; > >> > >> these are usually initialized only if got_frame = 1 > > > > Not sure what you want me to change here. frame->key_frame is changed > > just below .. > > This was a minor suggestion, I was just thinking that you could store > !!bytestream2_get_le16(gb) in a separate variable and initialize > frame->key_frame only after *got_frame = 1.
Sometimes we do that, sometimes we don't. I'd keep it as-is to minimize changes for now. Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
