On Fri, Apr 7, 2017 at 11:32 AM, Vittorio Giovara <vittorio.giov...@gmail.com> wrote: > On Thu, Apr 6, 2017 at 10:45 PM, James Almer <jamr...@gmail.com> wrote: >> Calling put_ebml_binary() with sizeof(private) as argument is currently >> only valid for Equirectangular projections. >> >> Signed-off-by: James Almer <jamr...@gmail.com> >> --- >> Please, be more careful when making cosmetic changes to make sure they >> don't also change how the code works. >> Not only this was writing invalid Cubemap files, but also dumping >> uninitialized data from stack in them. > > Hello James, > unfortunately this mistake was present in the original patch > (https://patches.libav.org/patch/63023/) and the cosmetic change you > mention was only to break the line past the 80th column. > Thanks for the fix anyway, probably Luca's approach is more future proof > though.
The issue wasn't present in the original patch because it used a separate (properly sized) private buffer, instead of using a shared one for all cases. - Hendrik _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
