On 17/04/2017 18:04, Vittorio Giovara wrote: > On Mon, Apr 17, 2017 at 9:48 AM, Luca Barbato <lu_z...@gentoo.org> wrote: >> print_str() cannot print NULL. >> >> Bug-Id: 1040 >> CC: libav-sta...@libav.org >> --- >> avtools/avprobe.c | 36 +++++++++++++++++++++++++++++++----- >> 1 file changed, 31 insertions(+), 5 deletions(-) > > I'm not sure about this. First of all these values are not invalid but > simply unknown.
So is it ok for you if I use Unknown (something) ? > Secondly I'm starting to think whether these name API should return a > simple "" instead of NULL. > Any opinions? I prefer NULL since it is easier to compare than ret[0], but I do not have a strong opinion in this regard. Just I'd rather have all the functions behave the same :) lu _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
