On Thu, Mar 16, 2017 at 05:48:09PM +0100, Anton Khirnov wrote:
> Quoting Diego Biurrun (2017-03-16 17:42:42)
> > On Thu, Mar 16, 2017 at 05:34:12PM +0100, Anton Khirnov wrote:
> > > --- a/libavcodec/mpeg4audio.h
> > > +++ b/libavcodec/mpeg4audio.h
> > > @@ -104,7 +104,45 @@ enum AudioObjectType {
> > > +static av_always_inline unsigned int avpriv_pce_copy_bits(PutBitContext
> > > *pb,
> > > +static av_always_inline int avpriv_copy_pce_data(PutBitContext *pb,
> > > GetBitContext *gb)
> >
> > Shouldn't you drop the avpriv_ prefix? Once inlined, these are no longer
> > semiprivate symbols available across library boundaries.
> >
>
> Well, I think it still needs to be namespaced somehow. ff_?
Most other static inline functions do not have an ff_ prefix, but some do.
You could leave it out or make it ff_, whatever you prefer...
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
