On 5/5/2017 5:32 PM, Luca Barbato wrote: > On 5/5/17 8:56 PM, James Almer wrote: >> On 4/30/2017 12:35 PM, James Almer wrote: >>> Based on the H264 SEI implementation. >>> >>> This will be mainly useful once support for SEI messages that can be >>> used by the hevc parser are implemented, like Picture Timing. >>> >>> Signed-off-by: James Almer <jamr...@gmail.com> >>> --- >>> libavcodec/hevc_sei.c | 77 >>> +++++++++++++++++++++++++-------------------------- >>> libavcodec/hevcdec.c | 49 +++++++++++++++++--------------- >>> libavcodec/hevcdec.h | 44 ++++++++++++++++++----------- >>> 3 files changed, 92 insertions(+), 78 deletions(-) >> >> Ping for set. > > HEVCSEIContext doesn't seem a context though, probably HEVCSEIInfo might > be a better name.
How about ATMMachine or PINNumber? :P Jokes aside, I personally agree with Hendrik. HEVCSEIContext is consistent with h264's naming. But if you insist i can change it to for example HEVCSEI, following the existing HEVCSPS/HEVCPPS/HEVCVPS structs for the corresponding NALUs. > > Beside that seems fine to me. > >> Btw, I could send a new version removing the logctx parameter, since i >> noticed after sending that it's unused in a bunch of these functions. > > Sounds a good idea. > > lu > _______________________________________________ > libav-devel mailing list > libav-devel@libav.org > https://lists.libav.org/mailman/listinfo/libav-devel > _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
