On 20/05/17 08:04, Anton Khirnov wrote:
> Quoting Mark Thompson (2017-05-14 23:24:11)
>> ---
>> libavcodec/cbs.c | 1 +
>> libavcodec/cbs_h264.h | 396 +++++++++++++++
>> libavcodec/cbs_h2645.c | 734 ++++++++++++++++++++++++++++
>> libavcodec/cbs_h264_syntax.c | 1099
>> ++++++++++++++++++++++++++++++++++++++++++
>> libavcodec/cbs_internal.h | 3 +
>> 5 files changed, 2233 insertions(+)
>> create mode 100644 libavcodec/cbs_h264.h
>> create mode 100644 libavcodec/cbs_h2645.c
>> create mode 100644 libavcodec/cbs_h264_syntax.c
>>
>
>> +
>> +typedef struct H264RawSPS {
>> + uint8_t forbidden_zero_bit;
>> + uint8_t nal_ref_idc;
>> + uint8_t nal_unit_type;
>
> Wouldn't it be better to aggegate those into a struct?
> In case we want to add support for various crap like MVC later.
Hmm, yes.
More generally, I should probably include more of the syntax in section 7 above
slice_data() and only give up when actually hitting crazy stuff from the
annexes. (After thinking about how much to do for H.265 that ended up being
the intent there, so being consistent seems sensible.)
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
