LGTM.

I haven't tested the patches so I'm not sure it works as expected. But
just looking at the code it seems to do the job.

There doesn't seem to be support for decoding to
DXGI_FORMAT_420_OPAQUE which is often available. But since it can't be
displayed or mapped to CPU I guess it's useless here. In some cases
that's the only available decoder though (some cellphones).

On Mon, May 22, 2017 at 4:02 PM, wm4 <nfx...@googlemail.com> wrote:
> Hopefully addresses most of the review comments.
>
> wm4 (6):
>   lavu: add new D3D11 pixfmt and hwcontext
>   lavc: set avctx->hwaccel before init
>   dxva: preparations for new hwaccel API
>   dxva: move d3d11 locking/unlocking to functions
>   dxva: add support for new dxva2 and d3d11 hwaccel APIs
>   avconv: remove old avconv_dxva2
>
>  Changelog                      |   1 +
>  avtools/Makefile               |   1 -
>  avtools/avconv.h               |   1 +
>  avtools/avconv_dxva2.c         | 440 -------------------------
>  avtools/avconv_opt.c           |  10 +-
>  configure                      |  21 +-
>  doc/APIchanges                 |   9 +
>  libavcodec/allcodecs.c         |   5 +
>  libavcodec/decode.c            |   4 +-
>  libavcodec/dxva2.c             | 732 
> +++++++++++++++++++++++++++++++++++++++--
>  libavcodec/dxva2_h264.c        |  36 +-
>  libavcodec/dxva2_hevc.c        |  32 +-
>  libavcodec/dxva2_internal.h    |  63 +++-
>  libavcodec/dxva2_mpeg2.c       |  32 +-
>  libavcodec/dxva2_vc1.c         |  54 ++-
>  libavcodec/h264_slice.c        |   3 +-
>  libavcodec/hevcdec.c           |   3 +-
>  libavcodec/mpeg12dec.c         |   1 +
>  libavcodec/vc1dec.c            |   1 +
>  libavcodec/version.h           |   4 +-
>  libavutil/Makefile             |   3 +
>  libavutil/hwcontext.c          |   4 +
>  libavutil/hwcontext.h          |   1 +
>  libavutil/hwcontext_d3d11va.c  | 490 +++++++++++++++++++++++++++
>  libavutil/hwcontext_d3d11va.h  | 160 +++++++++
>  libavutil/hwcontext_dxva2.h    |   3 +
>  libavutil/hwcontext_internal.h |   1 +
>  libavutil/pixdesc.c            |   4 +
>  libavutil/pixfmt.h             |  14 +-
>  libavutil/version.h            |   4 +-
>  30 files changed, 1617 insertions(+), 520 deletions(-)
>  delete mode 100644 avtools/avconv_dxva2.c
>  create mode 100644 libavutil/hwcontext_d3d11va.c
>  create mode 100644 libavutil/hwcontext_d3d11va.h
>
> --
> 2.11.0
>
> _______________________________________________
> libav-devel mailing list
> libav-devel@libav.org
> https://lists.libav.org/mailman/listinfo/libav-devel
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to