On Wed, Jun 7, 2017 at 12:20 PM, wm4 <nfx...@googlemail.com> wrote:
> On Wed, 7 Jun 2017 09:10:17 +0200
> Steve Lhomme <rob...@gmail.com> wrote:
>
>> On Tue, Jun 6, 2017 at 6:51 PM, wm4 <nfx...@googlemail.com> wrote:
>
>> > + // (avctx->pix_fmt is not updated yet at this point)
>> > + sctx->pix_fmt = avctx->hwaccel->pix_fmt;
>> > +
>> > + if (avctx->codec_id == AV_CODEC_ID_H264 &&
>> > + (avctx->profile & ~FF_PROFILE_H264_CONSTRAINED) >
>> > FF_PROFILE_H264_HIGH) {
>> > + av_log(avctx, AV_LOG_VERBOSE, "Unsupported H.264 profile for DXVA
>> > HWAccel: %d\n",avctx->profile);
>> > + return AVERROR(ENOTSUP);
>> > + }
>> > +
>> > + if (avctx->codec_id == AV_CODEC_ID_HEVC &&
>> > + avctx->profile != FF_PROFILE_HEVC_MAIN && avctx->profile !=
>> > FF_PROFILE_HEVC_MAIN_10) {
>> > + av_log(avctx, AV_LOG_VERBOSE, "Unsupported HEVC profile for DXVA
>> > HWAccel: %d\n", avctx->profile);
>> > + return AVERROR(ENOTSUP);
>> > + }
>>
>> MPEG2 should also be limited to FF_PROFILE_MPEG2_SIMPLE and
>> FF_PROFILE_MPEG2_MAIN profiles. And only one of the decoders can
>> support both.
>
> OK. I can add that. But I'll add it as a new patch later, as I'd really
> like to get this patch set merged. It won't change the API anyway.
>
> What do you mean by the latter sentence? It looks like both
> DXVA2_ModeMPEG2_VLD and DXVA2_ModeMPEG2and1_VLD should support
> the simple and main profiles.
>
Simple is a strict subset of Main (IIRC?), so I don't see why it
wouldn't work. DXVA in itself doesn't necessarily care about the
profile, as long as the bitstream is compatible otherwise.
- Hendrik
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
