On Wed, 7 Jun 2017 13:28:16 +0200
Diego Biurrun <di...@biurrun.de> wrote:

> On Wed, Jun 07, 2017 at 01:18:19PM +0200, wm4 wrote:
> > On Wed, 7 Jun 2017 13:09:15 +0200
> > Diego Biurrun <di...@biurrun.de> wrote:
> >   
> > > On Tue, Jun 06, 2017 at 06:51:07PM +0200, wm4 wrote:  
> > > > --- a/configure
> > > > +++ b/configure
> > > > @@ -2166,7 +2166,7 @@ zmbv_encoder_deps="zlib"
> > > >  
> > > >  # hardware accelerators
> > > >  d3d11va_deps="d3d11_h dxva_h ID3D11VideoDecoder"
> > > > -dxva2_deps="dxva2api_h DXVA2_ConfigPictureDecode"
> > > > +dxva2_deps="dxva2api_h DXVA2_ConfigPictureDecode ole32"    
> > > 
> > > This looks wrong. Why does dxva2 suddenly depend on ole32?  
> > 
> > Because it suddenly does. You can read the C code.  
> 
> Try removing it. "ole32" is not a thing in configure. Its presence in
> 
>   avconv_suggest="dxva2_lib ole32 psapi shell32"
> 
> is therefore a bug. Introduced by yours truly it seems...
> 
> > > > @@ -4877,6 +4877,10 @@ if enabled libxcb; then
> > > >          check_pkg_config libxcb_xfixes xcb-xfixes xcb/xfixes.h 
> > > > xcb_xfixes_get_cursor_image
> > > >  fi
> > > >  
> > > > +enabled d3d11va &&
> > > > +    check_type "windows.h d3d11.h" ID3D11VideoDevice ||
> > > > +    disable d3d11va    
> > > 
> > > This should be below
> > > 
> > >   check_type "d3d9.h dxva2api.h" DXVA2_ConfigPictureDecode 
> > > -D_WIN32_WINNT=0x0602  
> > 
> > Why?  
> 
> Because this is where all the types for the (Windows) acceleration APIs
> are tested.

Well, feel free to send patches to fix this after it's merged, as you
know better about these things than me.
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to