On Thu, 15 Jun 2017, John Stebbins wrote:
If AVCodecParameters.codec_tag is 'hvc1' use it instead of 'hev1' for h.265 streams. QuickTime (and other Apple software) requires 'hvc1'. --- libavformat/movenc.c | 1 + 1 file changed, 1 insertion(+)diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 0c1508f..2ff4270 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -4435,6 +4435,7 @@ const AVCodecTag codec_mp4_tags[] = { { AV_CODEC_ID_MPEG4 , MKTAG('m', 'p', '4', 'v') }, { AV_CODEC_ID_H264 , MKTAG('a', 'v', 'c', '1') }, { AV_CODEC_ID_HEVC , MKTAG('h', 'e', 'v', '1') }, + { AV_CODEC_ID_HEVC , MKTAG('h', 'v', 'c', '1') }, { AV_CODEC_ID_AAC , MKTAG('m', 'p', '4', 'a') }, { AV_CODEC_ID_MP4ALS , MKTAG('m', 'p', '4', 'a') }, { AV_CODEC_ID_MPEG2VIDEO , MKTAG('m', 'p', '4', 'v') }, -- 2.9.4
This (and the rest of your patches except 2/4 as you mentioned yourself) look good and are a sensible addition.
However what I'm left wondering is as a next step, after making this possible at all, is what should be the default? If the default isn't compatible with apple tools, I'm pretty sure it'll be a very frequently asked question at least. I guess it's doable via the -tag flag on the command line or something like that, but it feels a little clunky.
But don't let that hold up your patches, since they generally are a step in the right direction.
// Martin _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
