On Tue, 20 Jun 2017, Diego Biurrun wrote:
On Mon, Jun 19, 2017 at 03:52:46PM +0300, Martin Storsjö wrote:
The rtmp protocol uses nonblocking reads, to poll for incoming
messages from the server while publishing a stream. Prior to
94599a6de3822b13c94096d764868128f388ba28 and
d13b124eaf452b267480074b2e6946538ed03a6e, the tls protocol
handled the nonblocking flag.
Those commit logs claim that the tls protocol does not have to handle
the nonblocking flag, apparently it has to now. An explanation would
be illuminating.
It's more or less a revert of d13b124eaf452b267480074b2e6946538ed03a6e.
After chaining the IO calls to the underlying urlprotocol, we didn't need
to handle nonblocking mode here when the tls protocol was used in
blocking mode.
I had overlooked the fact that callers actually wanted to use it in
nonblocking mode as well (as the rtmps protocol does), and at that point
when I removed it, the fact that it supported nonblocking mode felt more
like a sideeffect, not a necessary feature in itself. But it is indeed
necessary for rtmps.
// Martin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
