Thanks Lu. I will go through the submitted changes to understand what the styling issues are.
-----Original Message----- From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca Barbato Sent: Thursday, June 22, 2017 5:39 PM To: libav-devel@libav.org Subject: Re: [libav-devel] [PATCH] NVENC Input Surface Optimization On 6/23/17 1:47 AM, Ben Chang wrote: > Hi, > > Please help review this nvenc patch for input surface optimization. > > This patch aims to reduce the number of input/output surfaces NVENC > allocates per session. Previous default sets allocated surfaces to 32 > (unless there is user specified param or lookahead involved). Having > large number of surfaces consumes extra video memory (esp for higher > resolution encoding). The patch changes the surfaces calculation for > default, B-frames, lookahead scenario respectively. > > Change in location of surfaces and async_depth determination. Putting > it prior to rate control setup. Current code limits lookahead depth to > be 27 (default surface (32) - P interval (1) - 4). > > The other change involves surface selection. Previously, if a session > allocates x surfaces, only x-1 surfaces are used (due to combination > of output delay and lock toggle logic). To prevent unused surfaces, > changing surface rotation to using predefined fifo. > > Miscellaneous - add "auto" option in level. (was approved in a > previous patch that never propagated into the repository) There are some style issue, beside that the logic seems fine. I'll amend and split the patch in a set of 3, please ping me if it doesn't land during the weekend. lu _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
