On 6/28/17 12:27 AM, Diego Biurrun wrote:
> From: "addr-see-the-webs...@aetey.se" <addr-see-the-webs...@aetey.se>
> 
> Now it is possible to adjust compression speed vs R/D when needed
> and also skip vintage player compatibility at will.


The wording is quite misleading, you are better than me at coming up
with good messages. This patch adds encoding tuning and settings.

> 
> Signed-off-by: Diego Biurrun <di...@biurrun.de>
> ---
>  libavcodec/cinepakenc.c | 97 
> +++++++++++++++++++++++++++++++++----------------
>  1 file changed, 65 insertions(+), 32 deletions(-)
> 
> diff --git a/libavcodec/cinepakenc.c b/libavcodec/cinepakenc.c
> index 8174540..619ee83 100644
> --- a/libavcodec/cinepakenc.c
> +++ b/libavcodec/cinepakenc.c
> @@ -23,9 +23,6 @@ OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR 
> OTHERWISE,
>  ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>  OTHER DEALINGS IN THE SOFTWARE.
>  
> - * TODO:
> - * - optimize: color space conversion, ...
> - * - implement options to set the min/max number of strips?
>   * MAYBE:
>   * - "optimally" split the frame into several non-regular areas
>   *   using a separate codebook pair for each area and approximating
> @@ -33,6 +30,9 @@ OTHER DEALINGS IN THE SOFTWARE.
>   *   (use quadtree splitting? a simple fixed-granularity grid?)
>   *
>   *
> + * version 2014-01-23 Rl
> + * - added option handling for flexibility
> + *
>   * version 2014-01-21 Rl
>   * - believe it or not, now we get even smaller files, with better quality
>   *   (which means I missed an optimization earlier :)
> @@ -72,6 +72,8 @@ OTHER DEALINGS IN THE SOFTWARE.

All the comments like that should be moved to the commit message. It
shouldn't stay in the code.


I do not have specific opinions on the code itself.
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to