On Sun, Jul 09, 2017 at 12:46:39AM +0200, Luca Barbato wrote: > On 7/8/17 11:48 PM, Luca Barbato wrote: > > Do not use skip_remaining to fully wipe the cache. > > Thanks to Uoti for pointing out the problem. > > > > CC: libav-sta...@libav.org > > Uoti suggested: > > bitstream: Avoid undefined behavior in bitstream_skip > > Do not use skip_remaining to fully wipe the cache, as this could do > a 64-bit shift of a 64-bit variable which is undefined behavior in > C. > Instead set the related variables to zero directly. > > Thanks to Uoti for pointing out the problem. > > CC: libav-sta...@libav.org
Add parentheses after the function names while you're at it: bitstream: Avoid undefined behavior in bitstream_skip() Do not use skip_remaining() to fully wipe the cache, as this could do a 64-bit shift of a 64-bit variable which is undefined behavior in C. Instead set the related variables to zero directly. Thanks to Uoti Urpala for pointing out the problem. CC: libav-sta...@libav.org OK Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
