On 10/12/2017 2:17 PM, Diego Biurrun wrote: > On Thu, Oct 12, 2017 at 01:02:57AM -0300, James Almer wrote: >> libxavs may require pthreads and libm at link time, and without >> said ldflags available as global extralibs, the check will fail. >> >> Regression since 7cb1d9e2dbbe5bf4652be5d78cdd68e956fa3d63 >> --- >> I tried replacing the require() check with a require_pkg_config() >> one, and while it included the pthreads ldflag when libxavs was >> compiled with pthreads support, it didn't include the libm one. >> Considering the project seems dead, trying to get the installed >> pkg-config file fixed is probably futile. >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- a/configure >> +++ b/configure >> @@ -4781,7 +4781,7 @@ enabled libx264 && require_pkg_config >> libx264 x264 "stdint.h x264.h" x >> -enabled libxavs && require libxavs "stdint.h xavs.h" >> xavs_encoder_encode -lxavs >> +enabled libxavs && require libxavs "stdint.h xavs.h" >> xavs_encoder_encode "-lxavs $pthreads_extralibs $libm_extralibs" > > Hmmmmm.... > > I don't like this. It's clearly a bug in libxavs that you are just working > around here. It should be fixed at the source. Even if libxavs itself may > be unfixable, it's certainly not unforkable.
Would anyone even bother forking and maintaining this thing? > > What problem do you have exactly? libxavs certainly works on my FATE instance > that checks all external libraries. I compiled libxavs with default settings, installed it, then configure --enable-libxavs failed at the libxavs check. config.log showed a lot of missing references to pthreads and math functions when trying to link the test using only -lxavs. As i said, the project's .pc file includes a pthreads ldflag (-lpthreads in my case) but not -lm when it's clearly needed (i know some systems don't), so switching to require_pkg_config() is evidently not enough. > > Diego > _______________________________________________ > libav-devel mailing list > libav-devel@libav.org > https://lists.libav.org/mailman/listinfo/libav-devel > _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
