Re: [libav-devel] PATCH] h2645: Allocate a single buffer per packet. Drastically reduces memory usage on pathological streams.

[Luca Barbato]

On 03/11/2017 19:23, Kieran Kunhya wrote:
This patch fixes very high memory usage on pathological streams.

this hunk seems spurious (and should not even compile with gcc).

diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c
index a7c71d9..2ddbbf9 100644
--- a/libavcodec/h264_parse.c
+++ b/libavcodec/h264_parse.c
@@ -349,7 +349,8 @@ int ff_h264_init_poc(int pic_field_poc[2], int *pic_poc,
 static int decode_extradata_ps(const uint8_t *data, int size, 
H264ParamSets *ps,
                                int is_avc, void *logctx)
 {
-    H2645Packet pkt = { 0 };
+    H2645Packet pkt;
+    memset(&pkt, 0, sizeof(pkt));
     int i, ret = 0;

     ret = ff_h2645_packet_split(&pkt, data, size, logctx, is_avc, 2, 
AV_CODEC_ID_H264, 1);

lu
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel