(I sent the first version of this mail to Gmane by mistake; I hope I can
stop it before it clutters anyone's mailbox. Sorry.)

Le duodi 22 frimaire, an CCXIX, Thomas Worth a écrit :
> So then why is this value even set? I think this is clearly wrong, as
> it is being set to 32 every time.

When you call setsockopt(SO_REUSEADDR), the option_len is set to
sizeof(int), although sizeof(int) is a build-time constant.

The AVFMT_RAWPICTURE flag implies that the data length is sizeof(AVFrame),
but testing the flag every time requires more code and is more likely to
lead to bugs.

> > Alternate question: what is the exact output format you are using?
> The wrapper/container is QuickTime.

Well, here is your answer:

git/ffmpeg $ grep AVFMT_RAWPICTURE libavformat/movenc.c
zsh: exit 1     grep AVFMT_RAWPICTURE libavformat/movenc.c

The QuickTime muxer is not a RAWPICTURE muxer.

>                                     Perhaps MOV requires pkt.size. Is
> it possible this is wrapper-dependent?

You are checking a flag of the output container format, what do you expect?

>                                                   But it is not
> pointing to the struct itself, it is pointing to the struct definition
> which is always 32.

Read the code:

        pkt.data= (uint8_t *)picture;
        pkt.size= sizeof(AVPicture);

Maybe it would be more obvious that way (which is equivalent):

        pkt.data= (uint8_t *)picture;
        pkt.size= sizeof(picture);

Regards,

-- 
  Nicolas George

Attachment: signature.asc
Description: Digital signature

_______________________________________________
libav-user mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/libav-user

Reply via email to