Erik Van Grunderbeeck wrote: > >Did you try if C99 version works with ICC ? Something like: > > >#define DEBUG(MASK,...) bd_debug(__FILE__,__LINE__,MASK,__VA_ARGS__) > > It's in my backlog. I had to rewrite the function to enable the va_args, but > haven't send it yet.
If it works, I can change it to the original patch (it's already in my tree, tested with gcc). > I am copying code from my original git to a new one, testing and sending to > enable sequential patch sending. > > >TRACE() should be possible to disable at build time (by default) when > >the module is stable enough. It is already disabled in m2ts demuxer and > >graphics processor, but the patch enables it again :) > > >To be generic enough BD_ERROR() should take also debug mask, so it would > >look something like > > >#define BD_ERROR(MASK,...) > >bd_debug(__FILE__,__LINE__,MASK|DBG_CRIT,__VA_ARGS__) > > Ill make those changes then if ya want. I just moved everything together as a > start. > TRACE is a windows kinda thing, and although it didnt interfear with the > build renaming is an old habit No need for new patch (at least yet), I can sed those too. > >This seems to be unrelated change ? > >I don't think changing the environment variables back to (very common) > >names is good. Those were changed to BD_* when those collapsed with > >libaacs ones. ' > > Oops sry, I missed that one. Grep's fault <grin> Ok, dropped that chunk. _______________________________________________ libbluray-devel mailing list [email protected] http://mailman.videolan.org/listinfo/libbluray-devel
