On Wed, 20.08.08 16:53, Joe Marcus Clarke ([EMAIL PROTECTED]) wrote:

> This adds the necessary error checking, and fixes the s/alsa/oss/
> problem in configure.ac.

This patch got corrupted due to line break. 

> +    val = ca_sound_file_get_nchannels(out->file);
> +    if (ioctl(out->pcm, SNDCTL_DSP_CHANNELS, &val) < 0)
> +        goto finish;

Still missing the test here if val is correct.

I'll fix these two issues manually now, and apply the patch. 

I assume you checked out the libcanberra via git, didn't you? If you
did that it is actually trivial to send me a properly formatted patch:
just use git-format-patch. Next time, please use g-f-p, thank you!

Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net         ICQ# 11060553
http://0pointer.net/lennart/           GnuPG 0x1A015CC4
_______________________________________________
libcanberra-discuss mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/libcanberra-discuss

Reply via email to