On Fri, 29.08.08 00:00, Brian Cameron ([EMAIL PROTECTED]) wrote: >> Brian, I will release libcanberra 0.8 shortly. If you want to make >> sure that the Gst driver works fine on solaris before I do the >> release, please test quickly! > > Sorry I was not able ot test before the release. I just tested, and > I found it doesn't work for two reasons. One reason I fixed in the > attached patch. On Solaris, it is necessary to include "audioconvert ! > audioconfig" in the GStreamer pipeline. This is needed to ensure that > GStreaner "just works" with sink plugins that may not implement the > full range of possible output that can come out of decodebin. > > The attached patch fixes this. Totem, rhythmbox, and other GStreamer > based programs use similar logic.
Applied in 132428efdd117a182dec90f457a286abf1201d9f. Next time, please try to submit patches that follow the indenting of the rest of the file. Oh, and git formatted patches strongly preferred! > The second problem is that after fixing the above, canberra-gtk-play > just immediately returns and does not play the file. I believe the > issue is somehow in the bus_cb function, since it does work much > better and plays the file if I comment out these lines from the > driver_play function: > > /* > bus = gst_pipeline_get_bus(GST_PIPELINE (out->pipeline)); > gst_bus_set_sync_handler(bus, bus_cb, out); > gst_object_unref(bus); > */ > > However, after commenting out those lines, it seems that > canberra-gtk-play hangs after playing the file and never exits. > I suspect this is probably because the bus_cb is supposed to > catch this. But, for some reason, this doesn't seem to be > working on Solaris. I'm not sure why. As pointed out in that other email, this is certainly a bug which needs to be fixed. Lennart -- Lennart Poettering Red Hat, Inc. lennart [at] poettering [dot] net ICQ# 11060553 http://0pointer.net/lennart/ GnuPG 0x1A015CC4 _______________________________________________ libcanberra-discuss mailing list [email protected] https://tango.0pointer.de/mailman/listinfo/libcanberra-discuss
