Hello Ubuntu Packagers.

Please fix your package. You currently do not implement the Sound Theme
Spec because you patch libcanberra to change the FALLBACK_THEME define
to "ubuntu" rather than "freedesktop".

This is *invalid*. Change the DEFAULT_THEME by all means (I'd personally
not patch libcanberra and do it via the Desktop Environment but each to
their own).


As per the Sound Theme Spefification
(http://0pointer.de/public/sound-theme-spec.html):


Sound Lookup

...

The lookup is done first in the current theme, and then recursively in
each of the current theme's parents, and finally in the default theme
called "freedesktop" (implementations may add more default themes before
"freedesktop", but "freedesktop" must be last). A last fallback is
unthemed sound. As soon as there is a sound that matches in a theme, the
search is stopped.

...


So as you can see the "freedesktop" sound theme being the fallback is
*part of the specification*. By patching it out of the way you are
*breaking compatibility*.

I just waisted a couple hours trying to debug an issue with a user
because of this (related to speaker test sounds in the freedesktop theme).

Please get your house in order.

Thanks

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

_______________________________________________
libcanberra-discuss mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/libcanberra-discuss

Reply via email to