My only concern is if people have to search and install a bunch of other packages just to build libcdio. That's a fast way to get people to toss libcdio without giving it a second look. I almost didn't bother with it at all for this reason.
On 3/8/07, R. Bernstein <[EMAIL PROTECTED]> wrote:
Diego 'Flameeyes' Pettenò writes: > Hi all, Hey, good to see you're still there doing good things!a > > I got reported by Mich from FreeBSD of a PR reported to him [1] about failures > in building libcdio while having -I/usr/include in the commandline (which > albeit rare makes a bit of sense). I think basically the report was saying that #include <getopt.h> was used where it should have been #include "getopt.h> Although the report suggests several source files that this happens, I could only find one. Nevertheless I've made the simple change. > > I've looked into it, and I do think that the inconditional use of the > alternative getopt() function is suboptimal, although obviously needed for > systems like Solaris and similar. > > Luckily the problem was already considered more than once, and there's > gnulib[2] to take care of it. I've tried it locally and it's trivial to just > import the gnulib module (and its dependency), and should solve the problem > entirely; it does use about 100KB more for this though. > > Comments? Anything that simplifies and regularizes I'm for. As for the extra space, I don't think that should be a big concern. Some distributions like Debian, break out the command-tool part that uses getopts into a separate package. Of course as always, I'm am eager to hear what others think too. > > > [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/108953 > [2] http://www.gnu.org/software/gnulib/ > -- > Diego "Flameeyes" Pettenò > http://farragut.flameeyes.is-a-geek.org/ > > _______________________________________________ > Libcdio-devel mailing list > [email protected] > http://lists.gnu.org/mailman/listinfo/libcdio-devel _______________________________________________ Libcdio-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/libcdio-devel
_______________________________________________ Libcdio-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/libcdio-devel
