Hi, Pete Batard wrote: > provided Thomas doesn't have objections about this proposal
The code looks good to me. Any mistake with from_733() should have shown up by wrong file sizes being reported. from_723() on the other hand seems to have one single caller: function iso9660_get_pvd_block_size() in lib/iso9660/iso9660.c. with a single caller, too: ISO9660::PVD::get_pvd_block_size in lib/cdio++/iso9660.cpp. No caller of this is to see in libcdio. But both, the C and the C++ function, are part of the API. Result with any ISO in the wild should always be 2048. Have a nice day :) Thomas
