Sure. Makes sense. As Knuth says, "premature optimization is the root of evil".
On Wed, Jun 6, 2018 at 11:43 AM, Pete Batard <[email protected]> wrote: > Hi, > > I took the liberty of pushing a commit that removes inlining for 2 > specific Win32 static calls in driver/image/bincue.c and driver/image/nrg.c. > > Considering that recent compilers are usually smart enough about inlining > what can be inlined, I don't think this removal should harm us any. > > This is to address the following warnings when compiling with MinGW32: > > image/bincue.c: In function 'cdio_get_devices_bincue': > image/bincue.c:992:20: warning: inlining failed in call to > 'Win32Glob.constprop': call is unlikely and code size would grow [-Winline] > static inline void Win32Glob(const char* pattern, const char* szCurPath, > char ***drives, unsigned int *num_files) > ^~~~~~~~~ > image/bincue.c:1016:7: note: called from here > Win32Glob(pattern, szPath, drives, num_files); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > image/nrg.c: In function 'cdio_get_devices_nrg': > image/nrg.c:1128:20: warning: inlining failed in call to > 'Win32Glob.constprop': call is unlikely and code size would grow [-Winline] > static inline void Win32Glob(const char* pattern, const char* szCurPath, > char ***drives, unsigned int *num_files) > ^~~~~~~~~ > image/nrg.c:1152:7: note: called from here > Win32Glob(pattern, szPath, drives, num_files); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > You can see the details of this commit at: > http://git.savannah.gnu.org/cgit/libcdio.git/commit/?id=81d5 > c7bc6c162c17362d954e86de8971605d52ef > > Regards, > > /Pete > >
