On Mon, Apr 06, 2009 at 01:50:31PM +0530, Balbir Singh wrote: > * Bharata B Rao <[email protected]> [2009-04-06 13:19:29]: > > > On Wed, Apr 01, 2009 at 01:27:47PM +0200, Jan Safranek wrote: > > > Bharata B Rao wrote: > > >> /bin/sh ../../libtool --tag=CC --mode=link gcc -g -O2 -Wall > > >> -L../../src/.libs -o cgrulesengd cgrulesengd.o > > >> ../../src/.libs/libcgroup.la -lcgroup mkdir .libs > > >> gcc -g -O2 -Wall -o .libs/cgrulesengd cgrulesengd.o > > >> -L/home/bharata/libcg/src/.libs ../../src/.libs/libcgroup.so > > >> /home/bharata/libcg/src/.libs/libcgroup.so /usr/local/lib/libcgroup.so > > >> -lpthread -Wl,--rpath -Wl,/usr/local/lib > > > > > > The cause is probably -lcgroup and its transformation to > > > /usr/local/lib/libcgroup.so by libtool. > > > > > > Question is, why -lcgroup is there at all... All leads to following line > > > in configure.in: > > > AC_CHECK_LIB([cgroup], [cgroup_create_cgroup]) > > > > > > Why it's there? If we compile libcgroup, we do not need it installed and > > > we do not need to check it, right? Or am I missing something? Git shows > > > me that the line was there since beginning of the repository, so there > > > probably was some reason. > > > > Dhaval, Balbir, > > > > Do you know why this check is present ? The library compiles, installs > > and works (works as in it successfully runs a few test programs from tests/) > > with the above check removed. > > > > W/o a fix for this, it is painful as we have to everytime remove previous > > installations of libcg. > > > > Hi, Bharata, > > I added it in the beginning, mostly to make sure that > cgroup_create_cgroup is present and accessible to the test cases. Send > me a patch and I'll review/test it.
Here is the patch: [Note that I haven't modified configure file as it is a generated file and I believe you are going to remove it] -- Remove the dependency of libcgroup on libcgroup build. libcgroup build checks for the availability of cgroup_creat_cgroup from libcgroup during its build. This causes a build failure if libcgroup is compiled in a system which already has libcgroup library installed. Remove this check from configure.in. Signed-off-by: Bharata B Rao <[email protected]> --- configure.in | 3 --- 1 file changed, 3 deletions(-) --- a/configure.in +++ b/configure.in @@ -48,9 +48,6 @@ fi AM_PROG_LEX AC_PROG_LIBTOOL -# Checks for libraries. -AC_CHECK_LIB([cgroup], [cgroup_create_cgroup]) - # Checks for header files. AC_HEADER_DIRENT AC_HEADER_STDC ------------------------------------------------------------------------------ _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
