On Fri, May 08, 2009 at 03:08:02PM +0900, Ken'ichi Ohmichi wrote:
> 
> Hi Dhaval,
> 
> Dhaval Giani wrote:
> >>> diff --git a/scripts/init.d/cgred b/scripts/init.d/cgred
> >>> index fa824df..11b626d 100644
> >>> --- a/scripts/init.d/cgred
> >>> +++ b/scripts/init.d/cgred
> >>> @@ -32,14 +32,8 @@
> >>>  #                        cgroups to classify processes
> >>>  ### END INIT INFO
> >>>  
> >>> -prefix=/usr
> >>> -exec_prefix=/usr
> >>> -bindir=/bin
> >>> -
> >>> -CGRED_BIN=${exec_prefix}/${bindir}/cgrulesengd
> >>> -
> >>> -# Sanity checks
> >>> -[ -x $CGRED_BIN ] || exit 1
> >>> +PATH=$PATH:/sbin/:/usr/sbin
> >>> +CGRED_BIN=cgrulesengd
> >>>  
> >>>  # Source function library & LSB routines
> >>>  . /etc/rc.d/init.d/functions
> >> I confirmed your above patch works fine, so I think your patch is good.
> >> How about applying it to git tree ?
> >>
> > 
> > Hmmm. I thought I had applied an alternate patch which I had missed.
> > Thanks for pointing it out. Can you please pull now and try. There will
> > be a script generated on running configure.
> 
> I pulled the latest code, but it is not enough.
> A cgrulesengd command is installed into /sbin, but the path is "/bin" in
> /etc/init.d/cgred script.
> 
>  prefix=/usr;exec_prefix=/usr;bindir=/bin
>  CGRED_BIN=$bindir/cgrulesengd
> 
> So they mismatch still.
> The attached patch is necessary.
> 

Thanks, we mised that in the review!

> 
> Thanks
> Ken'ichi Ohmichi
> 
> ---
> [PATCH] Fix the path of cgrulesengd command.
> 
> 
> Signed-off-by: Ken'ichi Ohmichi <[email protected]>
> ---
> diff -rpuN a/scripts/init.d/cgred.in b/scripts/init.d/cgred.in
> --- a/scripts/init.d/cgred.in 2009-05-08 14:15:25.000000000 +0900
> +++ b/scripts/init.d/cgred.in 2009-05-09 00:00:11.021511704 +0900
> @@ -32,8 +32,8 @@
>  #                    cgroups to classify processes
>  ### END INIT INFO
> 
> -pref...@prefix@;exec_pref...@exec_prefix@;bind...@bindir@
> -CGRED_BIN=$bindir/cgrulesengd
> +pref...@prefix@;exec_pref...@exec_prefix@;sbind...@sbindir@
> +CGRED_BIN=$sbindir/cgrulesengd
> 
>  # Sanity checks
>  [ -x $CGRED_BIN ] || exit 1

-- 
regards,
Dhaval

------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image 
processing features enabled. http://p.sf.net/sfu/kodak-com
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to