I know there are use cases where /sysdefault group makes sense, but there are plenty of there where not - it always depends on controller and use case. And IMHO there are more use cases where /sysdefault is not needed - at least I did not need it during my experiments.
I propose to get rid of this automation and don't create the default group. Let user decide, if it is created or not. Eventually I might add default configuration for the controllers, which are not usable without it (if there are any). Signed-off-by: Jan Safranek <[email protected]> --- scripts/init.d/cgconfig.in | 49 -------------------------------------------- 1 files changed, 0 insertions(+), 49 deletions(-) diff --git a/scripts/init.d/cgconfig.in b/scripts/init.d/cgconfig.in index 543cb9f..1a13231 100644 --- a/scripts/init.d/cgconfig.in +++ b/scripts/init.d/cgconfig.in @@ -89,55 +89,6 @@ start() { fi fi - declare defaultcgroup - - if [ -f /etc/cgrules.conf ] - then - read user ctrl defaultcgroup <<< \ - `grep -m1 ^\* /etc/cgrules.conf` - if [[ -n $defaultcgroup && $defaultcgroup = "*" ]] - then - log_warning_msg "/etc/cgrules.conf incorrect" - log_warning_msg "Overriding it" - defaultcgroup= - fi - fi - - if [ -z $defaultcgroup ] - then - defaultcgroup=sysdefault/ - fi - # - # Create a default class for tasks to return back to - # - parse_mounts - for i in `seq 1 $maxindex` - do - # - # Ignore if directory already exists - # - mkdir ${MOUNTPOINT[$i]}/$defaultcgroup 2> /dev/null - chmod a+rw ${MOUNTPOINT[$i]}/$defaultcgroup/tasks - # - # special rule for cpusets - # - echo ${MOUNTOPTS[$i]} | grep -q -w cpuset - if [ $? -eq 0 ] - then - cat ${MOUNTPOINT[$i]}/cpuset.cpus > \ - ${MOUNTPOINT[$i]}/$defaultcgroup/cpuset.cpus - cat ${MOUNTPOINT[$i]}/cpuset.mems > \ - ${MOUNTPOINT[$i]}/$defaultcgroup/cpuset.mems - fi - # - # classify everything to default cgroup - # - for j in `ps --no-headers -eL o tid` - do - echo $j > ${MOUNTPOINT[$i]}/$defaultcgroup/tasks 2>/dev/null - done - done - touch /var/lock/subsys/$servicename retval=$? if [ $retval -ne 0 ] ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
