Hi Dhaval, Dhaval Giani wrote: >> [PATCH-v2 1/2] Cleanup: Rename ECGROUPPARSEFAIL to ECGRULESPARSEFAIL. >> >> Changelog since v1: >> o A new patch [Cleanup: Rename ECGROUPPARSEFAIL to ECGRULESPARSEFAIL.] >> >> >> Now ECGROUPPARSEFAIL is defined for a parser error of /etc/cgrules.conf and >> this patch renames ECGROUPPARSEFAIL to ECGRULESPARSEFAIL for clarifying its >> meaning. >> > > This patch will break ABI.
You are right, that is my mistake. I'm sorry. > Why don't we just do > > #define ECGRULESPARSEFAIL ECGROUPPARSEFAIL That is good idea, I created a new patch based on the above. Thanks Ken'ichi Ohmichi --- commit 5280caebcd9ad2b3bb3badc518db2c8c3e320db0 Author: Ken'ichi Ohmichi <[email protected]> Date: Wed Nov 4 09:54:33 2009 +0900 [PATCH-v3 1/2] Cleanup: Define ECGRULESPARSEFAIL for the parser error of cgrules.conf. Changelog since v2: o Define ECGRULESPARSEFAIL for avoiding breaking ABI. Changelog since v1: o A new patch [Cleanup: Rename ECGROUPPARSEFAIL to ECGRULESPARSEFAIL.] Now ECGROUPPARSEFAIL is defined for a parser error of /etc/cgrules.conf and this patch defines ECGRULESPARSEFAIL for the same value for clarifying its meaning. Signed-off-by: Ken'ichi Ohmichi <[email protected]> diff --git a/include/libcgroup.h b/include/libcgroup.h index f424562..52f79f8 100644 --- a/include/libcgroup.h +++ b/include/libcgroup.h @@ -90,6 +90,8 @@ enum cgroup_errors { ECGEOF, /* End of file, iterator */ }; +#define ECGRULESPARSEFAIL ECGROUPPARSEFAIL + /* * Don't use CGROUP_WALK_TYPE_FILE right now. It is added here for * later refactoring and better implementation. Most users *should* diff --git a/src/api.c b/src/api.c index a0e1b9b..28c0c3d 100644 --- a/src/api.c +++ b/src/api.c @@ -591,7 +591,7 @@ destroyrule: cgroup_free_rule(newrule); parsefail: - ret = ECGROUPPARSEFAIL; + ret = ECGRULESPARSEFAIL; close: fclose(fp); @@ -2366,7 +2366,7 @@ int cgroup_reload_cached_rules() if (ret) { cgroup_dbg("Error parsing configuration file \"%s\": %d.\n", CGRULES_CONF_FILE, ret); - ret = ECGROUPPARSEFAIL; + ret = ECGRULESPARSEFAIL; goto finished; } ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
