IMHO most of users don't need sysdefault group being created during boot - it's quite slow and at least in Fedora there is no application using it.
So, let users to configure it and turn the sysdefault off in default config. Of course, as package maintainer in some distros, I can enable/disable the sysdefault using simple patch, so the default config in official libcgroup.tar.gz is not that important and you may choose different default setup if you like. And when modifying this part of init script, put the default group creation to separate function, just to keep it clean. Signed-off-by: Jan Safranek <[email protected]> --- scripts/init.d/cgconfig.in | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/scripts/init.d/cgconfig.in b/scripts/init.d/cgconfig.in index 13c16f8..6e3bb86 100644 --- a/scripts/init.d/cgconfig.in +++ b/scripts/init.d/cgconfig.in @@ -48,6 +48,12 @@ servicename=cgconfig # . /lib/lsb/init-functions +# read the config +CREATE_DEFAULT=no +if [ -e /etc/sysconfig/cgconfig ]; then + . /etc/sysconfig/cgconfig +fi + parse_mounts() { while read name mountpt fs opts other do @@ -140,7 +146,9 @@ start() { fi fi - create_default_groups + if [ $CREATE_DEFAULT == "yes" ]; then + create_default_groups + fi touch /var/lock/subsys/$servicename retval=$? ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
