On Tue, 09.03.10 20:15, Balbir Singh ([email protected]) wrote: > > * Lennart Poettering <[email protected]> [2010-03-09 14:08:45]: > > > On Mon, 08.03.10 12:45, Jan Safranek ([email protected]) wrote: > > > > > Remove GNU_SOURCE from public headers, it has unpredictable consequences > > > on > > > applications using libcgroup.h > > > > Instead of defining _GNU_SOURCE on your own it is probably a much better > > idea to use AC_USE_SYSTEM_EXTENSIONS in configure.ac. > > > > My concern is that AC_USE_SYSTEM_EXTENSIONS is like a big tap, it > enables loads of other things like > > _ALL_SOURCE > _POSIX_PTHREAD_SEMANTICS > _TANDEM_SOURCE > > Am I missing something?
Sure, but where's the problem with this? libcg is Linux-specific anyway. AC_USE_SYSTEM_EXTENSIONS enables the full Linux API. Every single API call there is on Linux. And for something that is Linux-specific anyway, this should be the exact right thing to do. Only if you care about portability to non-Linux systems it makes sense to limit yourself to a minimal, portable API subset. But that is clearly not the case here. Lennart -- Lennart Poettering Red Hat, Inc. lennart [at] poettering [dot] net http://0pointer.net/lennart/ GnuPG 0x1A015CC4 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
