[
https://issues.apache.org/jira/browse/LIBCLOUD-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032326#comment-13032326
]
Roman Bogorodskiy commented on LIBCLOUD-83:
-------------------------------------------
A couple of questions/remarks:
* Why did you decide to go with a separate driver from Rackspace? Rackspace
1.0 and 1.1 APIs looks quite common, what's the reason not to use the same base
for these drivers?
* You have added a couple of *.xml fixtures which doesn't seem to be used
I have commented some parts of the diff on github. Some general comments:
* Please be consistent with your code style, e.g. if you write "foo = 2",
please then go with "bar = 3", not "bar=3" etc
* Please watch trailing spaces in your code (there are some in openstack.py)
* Please avoid commits like that:
https://github.com/griddynamics/libcloud/commit/60ee4599054f699a19f349baa695355f9256d854
in pull requests because when you override a whole file it makes reviewing
harder and additionally, makes 'git blame' less useful, so it's better to avoid
such things unless there are strong reasons behind it
* Please follow 'one feature - one pull request' strategy
Looking forward for your feedback,
Roman
> OpenStack driver
> ----------------
>
> Key: LIBCLOUD-83
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-83
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Reporter: Eugene Polyan
> Assignee: Roman Bogorodskiy
> Attachments: gd_libcloud_20110510.patch
>
>
> In order to suport OpenStack cloud platform the new driver is to be added to
> libcloud
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
