Tom Lane writes: > [email protected] writes: > > thanks for your explanation. I've checked the sources, and > > interestingly src/dbi_main.c contains a declaration of dbi_conn_queryf(): > > > dbi_result dbi_conn_queryf(dbi_conn Conn, const char *formatstr, ...) > > __attribute__ ((format (printf, 2, 3))); > > > in addition to the declaration in include/dbi/dbi.h: > > > dbi_result dbi_conn_queryf(dbi_conn Conn, const char *formatstr, ...); > > > Was that a half-assed attempt to implement what the OP asked for? > > Would it be sufficient to move the first declaration to the header > > which is visible to the programs that actually call the function? > > Right. The __attribute__() decoration needs to be visible to the call > sites, so generally one sticks it in the header that provides the > function's extern declaration. There's no point in attaching it to the > function definition. > > regards, tom lane
Thanks Tom. I've checked in the fixed files, see dbi.h.in rev. 1.14 and dbi_main.c rev. 1.104. Holger, could you please verify with your unintentional testcase whether you get the intended compiler warnings? regards, Markus -- Markus Hoenicka http://www.mhoenicka.de AQ score 38 ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ libdbi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libdbi-devel
