On Sat, Dec 22, 2007 at 06:18:12PM -0500, Jeff Squyres <[EMAIL PROTECTED]>
wrote:
> >>static struct ev_loop *
> >>ev_default_loop (unsigned int flags) { ... }
> >>
> >>Should that function be marked as inline?
> >
> >No, because inline semantics are not portable at the moment (C99 vs.
> >gcc),
> >so static is the closest equivalent.
>
> Also FWIW: AC_C_INLINE can take of this for you -- here's its
> description:
Jeff, please read what I wrote. You do not understand what inline means
and how C compilers generally work. I do not see how AC_C_INLINE is
relevant, as it doesn't tell me about inline _semantics_ and how to use
it, and it requires autoconf. Also, the current code and semantics are
*correct* and the wanted ones, and not using the inline function might
generate a warning as well, so silencing it in gcc is of little value.
If you are concerned, do not use -Wall in production builds (using -Wall
is basically a mistake in production builds as it includes an unknown,
often changing and sometimes broken set of warnings that will only scare
users). Please do not think that a warning indicates any problem with the
code whatsoever.
Because of our communications history, wouldn't it be possible to
"send" an actual developer who knows C and portability a bit? It is a
bit tiresome to have to explain C keywords and unix functions to you,
especially as portability issues require some experience, and my patience
admittedly has worn out a bit.
(Questions are ok, but if you do not like my answer because it doesn't
make sense to you you should first clarify it).
> >libev has been checked for relevant compiler warnings (on the
> >platforms
> >and with the compilers I use only of course).
>
> Fair enough. Is OS X one of those platforms? (I couldn't find an
> official list of supported platforms -- did I miss it?)
OS X is not one of those, but since afaics only gcc is used the warnings
should be comparable to similar platforms.
The list of official platforms is:
- POSIX (all)
- Winsockets (Windows 2000+, maybe earlier)
- Perls select emulation on windows
Currently this apparently rules out OS X (which is utterly, dearly,
almost unusably broken), but libev does survive its testsuites there
(with select, the only working backend on OS X), so while not officially
supported (due to lakc of resources) it should generally work there.
> A related (but probably random) question: are there any correctness
> tests for libev?
I use both the libevent regression tests and also have a number of tests
on my own (the latter are all part of the perl module).
> own stuff every night in an automated test harness; I'd be happy to
> add libev (standalone; outside of the other stuff I test) to the mix
> with a variety of platforms and compilers if it would be helpful.
Just run make test in the perl module, and if more is desired, use the
regression test in the libevent+libev tarball.
--
The choice of a Deliantra, the free code+content MORPG
-----==- _GNU_ http://www.deliantra.net
----==-- _ generation
---==---(_)__ __ ____ __ Marc Lehmann
--==---/ / _ \/ // /\ \/ / [EMAIL PROTECTED]
-=====/_/_//_/\_,_/ /_/\_\
_______________________________________________
libev mailing list
libev@lists.schmorp.de
http://lists.schmorp.de/cgi-bin/mailman/listinfo/libev
