On Thu, Sep 20, 2007 at 01:52:31PM +0200, Trond Norbye wrote:
> The result of gettime is not used if the timetree is empty (and might 
> cause a context switch to get the system clock).
> 
> --Trond

> Index: event.c
> ===================================================================
> --- event.c   (revision 440)
> +++ event.c   (working copy)
> @@ -804,24 +804,26 @@
>  void
>  timeout_process(struct event_base *base)
>  {
> -     struct timeval now;
> -     struct event *ev, *next;
> +     if (!RB_EMPTY(&base->timetree)) { 
> +             struct timeval now;
> +             struct event *ev, *next;

Why not just return if RB_EMPTY() is true rather than adding another level
of indention? Other than that, I also noticed this but didn't consider it as
anything significant. It has never once showed up as any significant source
of cycles in profiling either.

-cl
_______________________________________________
Libevent-users mailing list
Libevent-users@monkey.org
http://monkey.org/mailman/listinfo/libevent-users

Reply via email to