On Wed, Apr 15, 2009 at 01:01:00PM +0300, Marko Kreen wrote: > Given heap shape of: > > 1 > / \ > / \ > 10 3 > / \ / \ > 11 12 5 6 > > And now deleting '11', it seems to fail to keep heap property. > > The bug is probably hard to notice in practice as the events > will reach top anyway, only later than expected.
Got a patch for this? > Btw, I did not got feedback on my event struct size decreasing patch: > > http://monkeymail.org/archives/libevent-users/2008-July/001346.html > > 24 bytes on 64-bit platforms may not sound like a big memory saving, > but if we want to process tens or even hundreds of thousands of events > with maximum efficiency, then best use of CPU caches becomes important. > And there the bytes can matter. This looks pretty good. I'll apply it in 2.0; I'd prefer to leave the struct layout alone for the 1.4 series so as not to break binary compatibility more than necessary. BTW, if anybody else has any patches or code we seem to have totally dropped on the floor, could you upload them to the sourceforge tracker? Niels and I tend to do Libevent work in fits and starts, and between our productive periods, it's easy to lose track of what everybody else has done. -- Nick _______________________________________________ Libevent-users mailing list Libevent-users@monkey.org http://monkeymail.org/mailman/listinfo/libevent-users
