Hi Uwe,
On Monday, 18. August 2014 09:31:54 Rogier Wolff wrote:
> On Thu, Aug 14, 2014 at 03:43:01PM +0200, Uwe Bonnes wrote:
> > + fprintf(stdout,"Inversion on ");
> > + if (eeprom->rs232_inversion & INVERT_TXD) {
> > + fprintf(stdout,"TXD");
> > + i = 1;
> > + }
> > + if (eeprom->rs232_inversion & INVERT_RXD) {
> > + if (i)
> > + fprintf(stdout,", ");
> > + fprintf(stdout,"RXD");
> > + i = 1;
> > + }
>
> I would write this a bit different:
>
> Already at the first call of the helper function, the total code is
> less. When you reuse the helper, you start having /much/ less code...
>
> Oh, and my code does "one pin" / "two pins" correctly... :-)
>
> Roger.
any comment on Roger's comment? Any plans to update your patch?
Cheers,
Thomas
--
libftdi - see http://www.intra2net.com/en/developer/libftdi for details.
To unsubscribe send a mail to [email protected]
