On 08/20/2012 04:00 PM, Richard W.M. Jones wrote: > On Mon, Aug 20, 2012 at 03:51:54PM +0800, Wanlong Gao wrote: >> Add new api xfs_admin to change parameters of an XFS filesystem. >> >> Signed-off-by: Wanlong Gao <[email protected]> > > I've just realized that I forgot about the virt-diff patch that > you sent two weeks ago. Can you resend that, rebased?
Yes, I'll resend. ;) > > >> daemon/xfs.c | 78 >> ++++++++++++++++++++++++++++++++++++++++++ >> generator/generator_actions.ml | 21 ++++++++++++ ... > > What is the output of the xfs_admin command? I don't think we should > return unstructured strings, so either this output should be parsed if > it contains useful information, or it should be dropped. > OK, I'd like to drop it because the useful info can always be fetched from xfs_info. Thanks, Wanlong Gao _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
