On Mon, Dec 08, 2014 at 09:08:13AM -0500, John Eckersberg wrote: > "Richard W.M. Jones" <rjo...@redhat.com> writes: > > Hi John, > > > > Looks good. I've attached a slightly modified patch: > > > > - Don't need to define the WAIT_* timeout in the header file. > > > > - Call set_conversion_error in the subroutine, so that the > > real error can be propagated back to the user. > > > > - Use memcmp instead of strncmp. > > > > - Whitespace changes. > > > > What do you think? > > > > Rich. > > Looks good to me. Thanks Rich.
Thanks - pushed. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/ _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
