On Thu, Nov 05, 2015 at 05:17:03PM +0100, Pino Toscano wrote: > On Thursday 05 November 2015 16:10:05 Richard W.M. Jones wrote: > > Patch 1 moves the v2v/fake-virtio-win and v2v/fake-virt-tools > > directories to the recently created test-data/ hierarchy. This is > > just refactoring with no functional change at all. > > Ah, you did beat me to it :) > > As additional step, could we move to run(.in) the exports of > VIRT_TOOLS_DATA_DIR and VIRTIO_WIN? In case you need custom ones, you > can always run: ./run env VIRT_TOOLS_DATA_DIR=.. virt-v2v ..
I don't like that idea, for the same reason I don't like the idea of ./run.in setting XDG_CONFIG_DIRS=builder/test-website, and that is that it prevents you from doing: ./run virt-v2v -i disk windows.img ... and: ./run virt-builder fedora-22 Which was actually the reason I've been meaning to propose removing the setting of XDG_CONFIG_DIRS from run.in (moving it instead to the tests that need it). Rich. > > Patches 2-4 then extend the available (fake) virtio-win drivers: > > > > - Patch 2 adds all of the drivers from the virtio-win RPM. > > > > - Patch 3 adds all of the drivers from the virtio-win ISO (which are > > different from the virtio-win RPM, for various reasons that don't > > make sense). > > > > - Patch 4 adds bits of the *.inf files, which will allow us to do > > proper driver discovery in future. See Vadim's posting here: > > https://www.redhat.com/archives/libguestfs/2015-October/msg00352.html > > LGTM. > > -- > Pino Toscano > _______________________________________________ > Libguestfs mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/libguestfs -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
