On Sunday 20 March 2016 12:31:02 Richard W.M. Jones wrote:
> We're never going to use virtio-console since, although it is faster,
> it's not available during early boot, and that is more important for
> debugging.
> ---
> src/launch-direct.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/src/launch-direct.c b/src/launch-direct.c
> index a81d4b3..f1fe92b 100644
> --- a/src/launch-direct.c
> +++ b/src/launch-direct.c
> @@ -574,19 +574,9 @@ launch_direct (guestfs_h *g, void *datav, const char
> *arg)
> ADD_CMDLINE ("-device");
> ADD_CMDLINE (VIRTIO_SERIAL);
>
> -#if 0
> - /* Use virtio-console (a variant form of virtio-serial) for the
> - * guest's serial console.
> - */
> - ADD_CMDLINE ("-chardev");
> - ADD_CMDLINE ("stdio,id=console");
> - ADD_CMDLINE ("-device");
> - ADD_CMDLINE ("virtconsole,chardev=console,name=org.libguestfs.console.0");
> -#else
> /* When the above works ... until then: */This line ^ should be removed too, as it does not make much sense without the comments removed by this patch. With this fix, LGTM. Thanks, -- Pino Toscano
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
