(I don't have a BZ# for this yet, but I'm expecting it to be filed as an RFE)
Currently if the user is in the virt-p2v GUI and cancels the conversion, all that happens is we abruptly close the ssh session to virt-v2v. That is bad .. possibly (or maybe not). But in any case there is an alternative: we can send a ^C key to the virt-v2v process, which it could catch and handle gracefully, although it doesn't do that right now. Sending ^C turns out to be complex. It requires changes in miniexpect (http://git.annexia.org/?p=miniexpect.git;a=commitdiff;h=fb0eeddc671039cabd9c53934e324ae218b21000). Then we have to make sure the control connection to virt-v2v is opened in "cooked" mode. But we cannot open the control connection in cooked mode without also changing the way we are copying files over to the remote server, so I also had to implement 'scp' support. After all that the conversion code can be modified to send ^C when the connection is cancelled. Rich. _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
