On Friday, 9 September 2016 15:09:56 CEST Richard W.M. Jones wrote:
> Simple code motion.
> ---
>  v2v/Makefile.am        |  2 ++
>  v2v/input_disk.ml      | 21 ++-------------------
>  v2v/name_from_disk.ml  | 41 +++++++++++++++++++++++++++++++++++++++++
>  v2v/name_from_disk.mli | 24 ++++++++++++++++++++++++
>  4 files changed, 69 insertions(+), 19 deletions(-)
>  create mode 100644 v2v/name_from_disk.ml
>  create mode 100644 v2v/name_from_disk.mli

Looks good -- I'd have put it in Utils though, instead of a new module
with just a single simple function.

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Libguestfs mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libguestfs

Reply via email to