On Tuesday, 12 September 2017 19:04:18 CEST Richard W.M. Jones wrote:
> v2 -> v3:
> 
>  - I addressed everything that Pino mentioned last time.
> 
>  - It's tricky to get a stable run when multiple copies of qemu are
>    involved, because the same cache files get overwritten by parallel
>    libguestfs.  So I changed the names of the cache files to include
>    the qemu binary key (size, mtime), which removes this conflict.
>    This is in new patch 4/6.

LGTM, except for the concern I have about the point above, in patch #4.

Thanks,
-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Libguestfs mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libguestfs

Reply via email to